Timers cannot be started from another thread #2

Closed
opened 7 years ago by RomanZhilich · 7 comments
RomanZhilich commented 7 years ago (Migrated from github.com)
Owner

I'm using mail-notifier on OS X from terminal and output gets bloated with this message:

Object::startTimer: Timers cannot be started from another thread

That seems pretty weird, since timer started in the same place it's created. Moreover, if I understand correctly it should only be started once with QThread.
It seems that message appears once for every mail check performed.

I'm using mail-notifier on OS X from terminal and output gets bloated with this message: ``` Object::startTimer: Timers cannot be started from another thread ``` That seems pretty weird, since timer started in the same place it's created. Moreover, if I understand correctly it should only be started once with QThread. It seems that message appears once for every mail check performed.
rinaldus commented 7 years ago (Migrated from github.com)
Owner

Please specify, you see this warning every N minutes when it checks mail automatically or you also see warning when you check mail manually clicking "Context menu -> Check now"?

Please specify, you see this warning every N minutes when it checks mail automatically or you also see warning when you check mail manually clicking "Context menu -> Check now"?
RomanZhilich commented 7 years ago (Migrated from github.com)
Owner

"Context menu -> Check now" doesn't cause message to appear, only scheduled check.

"Context menu -> Check now" doesn't cause message to appear, only scheduled check.
rinaldus commented 7 years ago (Migrated from github.com)
Owner

I rewrote periodically mail check function. This code seems to work in Linux properly, but unfortunately I have not OS X to test it there. There are differences between Linux and OS X, because I don't see any warnings and errors in Linux terminal. I attached modified version. Please, test it. Since Github doesn't accept attachments with py extension, download my attachment, rename it to mail-notifier.py and copy it to your mail-notifier installation folder. Then tell me if this modified version works properly or not. If it work, I will commit it and close bug.

mail-notifier.txt

I rewrote periodically mail check function. This code seems to work in Linux properly, but unfortunately I have not OS X to test it there. There are differences between Linux and OS X, because I don't see any warnings and errors in Linux terminal. I attached modified version. Please, test it. Since Github doesn't accept attachments with py extension, download my attachment, rename it to mail-notifier.py and copy it to your mail-notifier installation folder. Then tell me if this modified version works properly or not. If it work, I will commit it and close bug. [mail-notifier.txt](https://github.com/rinaldus/mail-notifier/files/104604/mail-notifier.txt)
RomanZhilich commented 7 years ago (Migrated from github.com)
Owner

Thanks, I'll test it shortly.

P.S. Don't you think it would be more convenient to push your changes in separate branch?

Thanks, I'll test it shortly. P.S. Don't you think it would be more convenient to push your changes in separate branch?
rinaldus commented 7 years ago (Migrated from github.com)
Owner

No, I don't think, that this bug fix needs to push in separate branch. It seems, I wrote my initial periodical mail check function not quite correctly. This was passed by Linux, but in other platform there were issues, that I didn't know. I hope this function will work correctly in all platforms.
However, when I will start to add new features in program, I'm planning to do it in separate development branch to prevent making program unworkable.

No, I don't think, that this bug fix needs to push in separate branch. It seems, I wrote my initial periodical mail check function not quite correctly. This was passed by Linux, but in other platform there were issues, that I didn't know. I hope this function will work correctly in all platforms. However, when I will start to add new features in program, I'm planning to do it in separate development branch to prevent making program unworkable.
RomanZhilich commented 7 years ago (Migrated from github.com)
Owner

Well I just tested it and message seems to be gone now.

I don't think, that this bug fix needs to push in separate branch

I only meant that it would be more convenient to make changes and test. IMHO

Well I just tested it and message seems to be gone now. > I don't think, that this bug fix needs to push in separate branch I only meant that it would be more convenient to make changes and test. IMHO
rinaldus commented 7 years ago (Migrated from github.com)
Owner

Thank you for your help!

Thank you for your help!
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.