Rinaldus
/
mail-notifier
1
0
Fork 0
Code Issues 3 Pull Requests Projects Releases 8 Wiki Activity

Timers cannot be started from another thread #2

New Issue
Closed
opened 2016-01-26 00:25:22 +03:00 by RomanZhilich · 7 comments
RomanZhilich commented 2016-01-26 00:25:22 +03:00 (Migrated from github.com)
Copy Link

I'm using mail-notifier on OS X from terminal and output gets bloated with this message:

Object::startTimer: Timers cannot be started from another thread

That seems pretty weird, since timer started in the same place it's created. Moreover, if I understand correctly it should only be started once with QThread.
It seems that message appears once for every mail check performed.

I'm using mail-notifier on OS X from terminal and output gets bloated with this message: ``` Object::startTimer: Timers cannot be started from another thread ``` That seems pretty weird, since timer started in the same place it's created. Moreover, if I understand correctly it should only be started once with QThread. It seems that message appears once for every mail check performed.
rinaldus commented 2016-01-26 01:57:15 +03:00 (Migrated from github.com)
Copy Link

Please specify, you see this warning every N minutes when it checks mail automatically or you also see warning when you check mail manually clicking "Context menu -> Check now"?

Please specify, you see this warning every N minutes when it checks mail automatically or you also see warning when you check mail manually clicking "Context menu -> Check now"?
RomanZhilich commented 2016-01-26 02:00:47 +03:00 (Migrated from github.com)
Copy Link

"Context menu -> Check now" doesn't cause message to appear, only scheduled check.

"Context menu -> Check now" doesn't cause message to appear, only scheduled check.
rinaldus commented 2016-01-26 11:20:18 +03:00 (Migrated from github.com)
Copy Link

I rewrote periodically mail check function. This code seems to work in Linux properly, but unfortunately I have not OS X to test it there. There are differences between Linux and OS X, because I don't see any warnings and errors in Linux terminal. I attached modified version. Please, test it. Since Github doesn't accept attachments with py extension, download my attachment, rename it to mail-notifier.py and copy it to your mail-notifier installation folder. Then tell me if this modified version works properly or not. If it work, I will commit it and close bug.

mail-notifier.txt

I rewrote periodically mail check function. This code seems to work in Linux properly, but unfortunately I have not OS X to test it there. There are differences between Linux and OS X, because I don't see any warnings and errors in Linux terminal. I attached modified version. Please, test it. Since Github doesn't accept attachments with py extension, download my attachment, rename it to mail-notifier.py and copy it to your mail-notifier installation folder. Then tell me if this modified version works properly or not. If it work, I will commit it and close bug. [mail-notifier.txt](https://github.com/rinaldus/mail-notifier/files/104604/mail-notifier.txt)
RomanZhilich commented 2016-01-26 11:24:28 +03:00 (Migrated from github.com)
Copy Link

Thanks, I'll test it shortly.

P.S. Don't you think it would be more convenient to push your changes in separate branch?

Thanks, I'll test it shortly. P.S. Don't you think it would be more convenient to push your changes in separate branch?
rinaldus commented 2016-01-26 11:31:51 +03:00 (Migrated from github.com)
Copy Link

No, I don't think, that this bug fix needs to push in separate branch. It seems, I wrote my initial periodical mail check function not quite correctly. This was passed by Linux, but in other platform there were issues, that I didn't know. I hope this function will work correctly in all platforms.
However, when I will start to add new features in program, I'm planning to do it in separate development branch to prevent making program unworkable.

No, I don't think, that this bug fix needs to push in separate branch. It seems, I wrote my initial periodical mail check function not quite correctly. This was passed by Linux, but in other platform there were issues, that I didn't know. I hope this function will work correctly in all platforms. However, when I will start to add new features in program, I'm planning to do it in separate development branch to prevent making program unworkable.
RomanZhilich commented 2016-01-26 11:37:35 +03:00 (Migrated from github.com)
Copy Link

Well I just tested it and message seems to be gone now.

I don't think, that this bug fix needs to push in separate branch

I only meant that it would be more convenient to make changes and test. IMHO

Well I just tested it and message seems to be gone now. > I don't think, that this bug fix needs to push in separate branch I only meant that it would be more convenient to make changes and test. IMHO
rinaldus commented 2016-01-26 11:39:26 +03:00 (Migrated from github.com)
Copy Link

Thank you for your help!

Thank you for your help!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
3.01
3.0
2.0
2.0-beta1
1.02
1.01
1.0
0.10
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
feature request

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
feature request
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Rinaldus/mail-notifier#2
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?