The program didn't work when account didn't exist.

Also fixed crash when the program tried to load incorrect mail headers

LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2015-2016, Peter Svirshchevskiy
+Copyright (c) 2015-2017, Peter Svirshchevskiy
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
@@ -9,4 +9,4 @@ Redistribution and use in source and binary forms, with or without modification,
 
 3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
 
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

README.md

@@ -26,6 +26,11 @@ $ chmod +x mail-notifier.py
 
 ## Changelog
 
+### Version 3.01 (release date: 10.10.17)
+* Added status bar in Details window
+* Details window now remembers its size
+* Some cosmetic improvements in menu
+
 ### Version 3.0 (release date: 26.07.16)
 * System tray icon displays count of unread mail directly on itself
 * Popup notification behaviour was changed: now popup notification appears only if the number of unread emails has

mail-notifier.py

@@ -22,7 +22,7 @@ from datetime import datetime, date, time
 
 #variables
 programTitle = "Mail Notifier"
-programVersion = "3.0-dev"
+programVersion = "3.01-dev"
 settings = QSettings(os.path.expanduser("~")+"/.config/mail-notifier/settings.conf", QSettings.NativeFormat)
 def GlobalSettingsExist():
     if ((settings.contains("CheckInterval") and settings.value("CheckInterval") != "") and
@@ -87,6 +87,12 @@ class Window(QDialog):
         self.ui.btnSaveAccount.clicked.connect(self.btnSaveAccount_clicked)
         self.ui.btnRemoveAccount.clicked.connect(self.btnRemoveAccount_clicked)
         
+        # Check if account doesn't exist, it creates default one
+        if (AccountExist() == False):
+            self.ui.comboAccounts.addItem("Default")
+            self.ui.comboAccounts.setCurrentText("Default")
+                
+        
         # Main timer
         self.timer = QTimer(self)
         self.timer.timeout.connect(mail_check)
@@ -95,27 +101,32 @@ class Window(QDialog):
         
         # Menu actions
     def createActions(self):
-        self.detailsShow = QAction(QIcon(':icons/details.png'),"&Details", self, triggered=self.detailsShow)
-        self.aboutShow = QAction(QIcon(':icons/mailbox_empty.png'),"&About", self, triggered=self.aboutShow)
+        self.detailsShow = QAction(QIcon(':icons/details.png'),"&Details...", self, triggered=self.detailsShow)
+        self.aboutShow = QAction(QIcon(':icons/mailbox_empty.png'),"&About " + programTitle + "...", self, triggered=self.aboutShow)
         self.checkNow = QAction(QIcon(':icons/check_now.png'),"&Check now", self, triggered=mail_check)
-        self.restoreAction = QAction(QIcon(":icons/settings.png"),"&Settings", self, triggered=self.showNormal)
+        self.restoreAction = QAction(QIcon(":icons/settings.png"),"&Settings...", self, triggered=self.showNormal)
         self.quitAction = QAction(QIcon(':icons/menu_quit.png'),"&Quit", self, triggered=QApplication.instance().quit)
 
         # UI functions
     def createTrayIcon(self):
         self.trayIconMenu = QMenu(self)
-        self.trayIconMenu.addAction(self.aboutShow)
+        f = self.trayIconMenu.font()
+        f.setBold(True)
+        self.detailsShow.setFont(f)
         self.trayIconMenu.addAction(self.detailsShow)
+        self.trayIconMenu.addSeparator()
         self.trayIconMenu.addAction(self.checkNow)
         self.trayIconMenu.addAction(self.restoreAction)
+        self.trayIconMenu.addAction(self.aboutShow)
         self.trayIconMenu.addAction(self.quitAction)
         self.trayIcon = QSystemTrayIcon(self)
         self.trayIcon.setContextMenu(self.trayIconMenu)
-        #self.trayIcon.activated.connect(self.trayIconActivated)
+        self.trayIcon.activated.connect(self.trayIconActivated)
 
     def SettingsRestore(self):
         if (GlobalSettingsExist() and AccountExist()):
             groups = settings.childGroups()
+            self.ui.comboAccounts.clear() # Clear account items before fill them again
             for i in range (len(groups)):
                 self.ui.comboAccounts.addItem(groups[i])
                 self.ui.comboAccounts.setCurrentText(groups[i])
@@ -203,6 +214,10 @@ class Window(QDialog):
             GroupName = self.ui.comboAccounts.currentText()
             self.ui.comboAccounts.removeItem(Index)
             self.SettingsRemove(GroupName)
+        # Check if account doesn't exist, it creates default one
+        if (AccountExist() == False):
+            self.ui.comboAccounts.addItem("Default")
+            self.ui.comboAccounts.setCurrentText("Default")
             
     def comboAccounts_changed(self):
         self.ui.lblTestOutput.setText("")
@@ -247,7 +262,7 @@ class About(QDialog):
         self.ui = Ui_about()
         self.ui.setupUi(self)
         self.setWindowFlags(QtCore.Qt.Tool)
-        self.setFixedSize(483,334)
+        self.setFixedSize(511,334)
         
         self.ui.lblNameVersion.setText(programTitle + " " + programVersion)
         
@@ -269,9 +284,15 @@ class Details(QDialog):
         self.ui.setupUi(self)
         self.setWindowFlags(QtCore.Qt.Window)
         self.ui.btnRefresh.clicked.connect(self.Refresh_clicked)
+        if (settings.contains("Details_width") and settings.contains("Details_height")):
+            width = int(settings.value("Details_width"))
+            height = int(settings.value("Details_height"))
+            self.resize(width,height)
         
     def closeEvent(self, event):
         event.ignore()
+        settings.setValue("Details_width",self.width())
+        settings.setValue("Details_height",self.height())
         self.hide()
         
     def Refresh_clicked(self):
@@ -409,13 +430,17 @@ def mail_check():
         details.ui.tableWidget.setRowCount(len(AllFroms))
         details.ui.tableWidget.setColumnCount(3)
         #Enter data onto Table
-        horHeaders = []
-        for n, key in enumerate(sorted(data.keys())):
-            #print(data.keys())
-            horHeaders.append(key)
-            for m, item in enumerate(data[key]):
-                newitem = QtWidgets.QTableWidgetItem(item)
-                details.ui.tableWidget.setItem(m, n, newitem)
+        try:
+            horHeaders = []
+            for n, key in enumerate(sorted(data.keys())):
+                #print(data.keys())
+                horHeaders.append(key)
+                for m, item in enumerate(data[key]):
+                    newitem = QtWidgets.QTableWidgetItem(item)
+                    details.ui.tableWidget.setItem(m, n, newitem)
+        except:
+            print("Unable to load some data")
+            pass
         
         #Add Header
         details.ui.tableWidget.setHorizontalHeaderLabels(horHeaders)        
@@ -427,9 +452,12 @@ def mail_check():
     # check was successfull, lastCheckCount is updating
     window.lastCheckCount = mail_count
 def notify(message):
-    if settings.value("Notify"):
-        subprocess.Popen(['notify-send', programTitle, message])
-    return
+    try:
+        if settings.value("Notify"):
+            subprocess.Popen(['notify-send', programTitle, message])
+        return
+    except:
+        print(message)
     
 
     

ui/about.ui

@@ -6,7 +6,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>483</width>
+    <width>511</width>
     <height>334</height>
    </rect>
   </property>
@@ -60,7 +60,7 @@
     <rect>
      <x>200</x>
      <y>40</y>
-     <width>261</width>
+     <width>291</width>
      <height>31</height>
     </rect>
    </property>

ui_about.py

@@ -2,7 +2,7 @@
 
 # Form implementation generated from reading ui file 'ui/about.ui'
 #
-# Created by: PyQt5 UI code generator 5.6.1.dev1604271126
+# Created by: PyQt5 UI code generator 5.8.2
 #
 # WARNING! All changes made in this file will be lost!
 
@@ -11,7 +11,7 @@ from PyQt5 import QtCore, QtGui, QtWidgets
 class Ui_about(object):
     def setupUi(self, about):
         about.setObjectName("about")
-        about.resize(483, 334)
+        about.resize(511, 334)
         sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Fixed, QtWidgets.QSizePolicy.Fixed)
         sizePolicy.setHorizontalStretch(0)
         sizePolicy.setVerticalStretch(0)
@@ -31,7 +31,7 @@ class Ui_about(object):
         self.lblLogo.setScaledContents(True)
         self.lblLogo.setObjectName("lblLogo")
         self.lblNameVersion = QtWidgets.QLabel(about)
-        self.lblNameVersion.setGeometry(QtCore.QRect(200, 40, 261, 31))
+        self.lblNameVersion.setGeometry(QtCore.QRect(200, 40, 291, 31))
         self.lblNameVersion.setMinimumSize(QtCore.QSize(203, 0))
         font = QtGui.QFont()
         font.setPointSize(20)